-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyring migrate command doc #8979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm @cyberbono3, thanks! is this r4r?
e691eea
to
61ea86f
Compare
61ea86f
to
56052b7
Compare
@AmauryM Can you review it, please? |
@cyberbono3 In the SDK, we generally don't put the |
OK. Thanks for your clarification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should write a numbered list of how to migrate keypairs from Launchpad to Stargate?
- simd keys migrate <old_home_dir> --dry-run true
- (how do we test that the keypairs migrated?)
- simd keys migrate <old_home_dir> --dry-run false
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Barrie Byron <barrie.byron@tendermint.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
@Mergifyio backport release/v0.42.x |
* draft * update * address comments, ready for review * delete thr last line * Update docs/migrations/keyring.md Co-authored-by: Barrie Byron <barrie.byron@tendermint.com> * Update docs/migrations/keyring.md Co-authored-by: Barrie Byron <barrie.byron@tendermint.com> * Update docs/migrations/keyring.md Co-authored-by: Barrie Byron <barrie.byron@tendermint.com> * Update docs/migrations/keyring.md Co-authored-by: Barrie Byron <barrie.byron@tendermint.com> * Update docs/migrations/keyring.md Co-authored-by: Barrie Byron <barrie.byron@tendermint.com> * Update docs/migrations/keyring.md Co-authored-by: Barrie Byron <barrie.byron@tendermint.com> * Update docs/migrations/keyring.md Co-authored-by: Barrie Byron <barrie.byron@tendermint.com> * ready for review * Update docs/migrations/keyring.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> Co-authored-by: SaReN <sahithnarahari@gmail.com> Co-authored-by: Barrie Byron <barrie.byron@tendermint.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> (cherry picked from commit d5f5fe6)
Command
|
Co-authored-by: SaReN <sahithnarahari@gmail.com> Co-authored-by: Barrie Byron <barrie.byron@tendermint.com> Co-authored-by: Alessio Treglia <alessio@tendermint.com> Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> (cherry picked from commit d5f5fe6) Co-authored-by: Andrei Ivasko <cyberbono3@gmail.com>
Description
This is draft PR that describes keyring migrate command.
closes: #8769
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes